Failed tests (toml-test 1.4.0)

cyanskies / another-toml-cpp

MIT License

1 stars 0 forks source link

Failed tests (toml-test 1.4.0) #11

Closed cyanskies closed 11 months ago

cyanskies commented 11 months ago

Decoding:

[x] valid/spec/array-1 (unexpected newline when parsing array) Fixed in https://github.com/cyanskies/another-toml-cpp/commit/b84aa71d6ff8a4eec2246aaac328def0f8fbac4f

Encoding:

[x] valid/keys/quoted-unicode (key contains invalid unicode escape \ud800)
[x] valid/strings/quoted-unicode (string contains invalid unicode escape \ud800)

cyanskies commented 11 months ago

The two encoding tests are including characters from outside the Unicode Scalar Value ranges. I'm pretty sure these escape codes are supposed to be rejected.

cyanskies commented 11 months ago

This was being caused by the JSON parser used in https://github.com/cyanskies/another-toml-test. A function for parsing these unicode escape codes has been added in https://github.com/cyanskies/another-toml-cpp/commit/bd3a859024a46e2e14258505e1d65dc1aa2fd026 and the tests pass when the JSON strings are passed through the new function.