cyberbotics / webots_ros2

Webots ROS 2 packages
Apache License 2.0
389 stars 141 forks source link

add remappings to robot state publisher for ur5e example #841

Closed skpawar1305 closed 11 months ago

skpawar1305 commented 11 months ago

follow up to https://github.com/cyberbotics/webots_ros2/commit/f3045ad16c6c41b0edbf845f06391be5d0990022

Description robot state publisher's robot_description update service doesn't get called, and also doesn't subscribe to joint_states' topic, because of the namespace 'ur5e' added to the WebotsController add remappings to the robot state publisher node to fix it

Affected Packages List of affected packages:

skpawar1305 commented 11 months ago

adding a namespace to the node should've been better, but webotscontroller's service client calls incorrect topic '/ur5erobot_state_publisher/set_parameters' instead of '/ur5e/robot_state_publisher/set_parameters'

omichel commented 11 months ago

In that case, I believe we should fix the webots controller service client to call the correct topic.

skpawar1305 commented 11 months ago

Do you know why the tests are failing on rolling?

no