search

cyberbotics / webots_ros2

Webots ROS 2 packages
Apache License 2.0
389 stars 141 forks source link

Fix hw interface check #883

Closed omichel closed 5 months ago

omichel commented 5 months ago

Backport of https://github.com/cyberbotics/webots_ros2/pull/882

Yadunund commented 5 months ago

Looks like build succeeded on Rolling (main and testing) but tests are failing. Unfortunately I'm not familiar enough with the codebase to make any changes to fix tests.

omichel commented 5 months ago

I re-ran the tests and main/rolling passed... Probably some random failure...

Yadunund commented 5 months ago

Thanks @omichel! Could you bloom a new release for Rolling whenever you get a chance next?

omichel commented 5 months ago

I don't have time for this right now, you can do it yourself and I will be happy to help if needed. The instructions are here.

Yadunund commented 5 months ago

Hi @omichel would really appreciate your help with blooming the release. I'm not sure how the version increases work in this project. Further i won't be able to run bloom as I don't have the required access within ros2-gbp

omichel commented 5 months ago

I just proposed to add you here. Hopefully, this will be accepted and merged soon. The version numbering is based on the Webots version. The current version is version='2023.1.1', where '2023.1' matches with the Webots version, e.g., R2023b ('2023.0' means Webots R2023a) and the final '.1' means first release of the ROS 2 interface for Webots R2023b. Thus, if you want to make new release, the version should be increased to '2023.1.2' to mean it aims at Webots R2023a and is version 2.