search

cyberbotics / webots_ros2

Webots ROS 2 packages
Apache License 2.0
402 stars 148 forks source link

Bump Rolling to 2023.1.2 #892

Closed Yadunund closed 8 months ago

Yadunund commented 8 months ago

As discussed https://github.com/cyberbotics/webots_ros2/pull/891#issuecomment-1925230624

I've already updated the release repository to bloom from this rolling branch https://github.com/ros2-gbp/webots_ros2-release/pull/3

Once this is merged, I will tag rolling as 2023.1.2 and bloom a new release.

Yadunund commented 8 months ago

Hi @omichel,

The rolling branch here was created off the 2023.1.1 tag and only has 1 commit cherry-picked from master see comapre.

I tried to execute the plan in https://github.com/cyberbotics/webots_ros2/pull/891#issuecomment-1925230624 but the CI failures below (esp those that fail when running tests configured for the packages), indicate that the codebase needs a lot of changes before it can be bloomed again. (See failures below).

I think the best way forward is to take some time to address the issues before trying to bloom again. This unfortunately means that we'll need to perform the upcoming Rolling sync without the webots_ros2 packages. These packages can be restored again to Rolling once the issues are resolved and a new version is bloomed. I'm sorry about this. I will

Test failures on (testing, rolling)

  test/test_copyright.py .                                                 [  9%]
  test/test_system_driver.py .                                             [ 18%]
  test/test_system_epuck.py F                                              [ 27%]
  test/test_system_epuck_with_tools.py s                                   [ 36%]
  test/test_system_mavic.py .                                              [ 45%]
  test/test_system_tesla.py .                                              [ 54%]
  test/test_system_tiago.py s                                              [ 63%]
  test/test_system_turtlebot.py F                                          [ 72%]
  test/test_system_turtlebot_tutorial_navigation.py s                      [ 81%]
  test/test_system_turtlebot_tutorial_slam.py s                            [ 90%]
  test/test_system_universal_robot.py F                                    [100%]

Test failures on (testing, iron) and (main, iron)

2024-02-05T09:43:36.9477902Z ----------------------------- Captured stderr call -----------------------------
2024-02-05T09:43:36.9478221Z testAbbCaughtCan (test_system_universal_robot.TestUniversalRobot) ... FAIL
2024-02-05T09:43:36.9478495Z testUr5eJointStates (test_system_universal_robot.TestUniversalRobot) ... FAIL
2024-02-05T09:43:36.9478500Z 
2024-02-05T09:43:36.9478633Z ======================================================================
2024-02-05T09:43:36.9478877Z FAIL: testAbbCaughtCan (test_system_universal_robot.TestUniversalRobot)
2024-02-05T09:43:36.9479086Z ----------------------------------------------------------------------
2024-02-05T09:43:36.9479194Z Traceback (most recent call last):
2024-02-05T09:43:36.9479652Z   File "/root/target_ws/src/webots_ros2/webots_ros2_tests/test/test_system_universal_robot.py", line 82, in testAbbCaughtCan
2024-02-05T09:43:36.9480060Z     self.wait_for_messages(self.__node, Range, '/abb/abbirb4600/object_present_sensor', timeout=200,
2024-02-05T09:43:36.9480468Z   File "/root/target_ws/src/webots_ros2/webots_ros2_tests/webots_ros2_tests/utils.py", line 56, in wait_for_messages
2024-02-05T09:43:36.9481003Z     self.assertGreaterEqual(len(received_messages), messages_to_receive, 'Not enough messages have been received')
2024-02-05T09:43:36.9481315Z AssertionError: 0 not greater than or equal to 1 : Not enough messages have been received
2024-02-05T09:43:36.9481321Z 
2024-02-05T09:43:36.9481453Z ======================================================================
2024-02-05T09:43:36.9481714Z FAIL: testUr5eJointStates (test_system_universal_robot.TestUniversalRobot)
2024-02-05T09:43:36.9481915Z ----------------------------------------------------------------------
2024-02-05T09:43:36.9482028Z Traceback (most recent call last):
2024-02-05T09:43:36.9482492Z   File "/root/target_ws/src/webots_ros2/webots_ros2_tests/test/test_system_universal_robot.py", line 94, in testUr5eJointStates
2024-02-05T09:43:36.9482819Z     self.wait_for_messages(self.__node, JointState, '/ur5e/joint_states', timeout=200,
2024-02-05T09:43:36.9483233Z   File "/root/target_ws/src/webots_ros2/webots_ros2_tests/webots_ros2_tests/utils.py", line 56, in wait_for_messages
2024-02-05T09:43:36.9483706Z     self.assertGreaterEqual(len(received_messages), messages_to_receive, 'Not enough messages have been received')
2024-02-05T09:43:36.9484012Z AssertionError: 0 not greater than or equal to 1 : Not enough messages have been received`

Build failures on (testing, humble)

  --- stderr: webots_ros2_control
  /root/target_ws/src/webots_ros2/webots_ros2_control/src/Ros2Control.cpp: In member function ‘virtual void webots_ros2_control::Ros2Control::init(webots_ros2_driver::WebotsNode*, std::unordered_map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&)’:
  /root/target_ws/src/webots_ros2/webots_ros2_control/src/Ros2Control.cpp:101:24: error: ‘class hardware_interface::ResourceManager’ has no member named ‘activate_all_components’
    101 |       resourceManager->activate_all_components();
        |                        ^~~~~~~~~~~~~~~~~~~~~~~
  gmake[2]: *** [CMakeFiles/webots_ros2_control.dir/build.make:76: CMakeFiles/webots_ros2_control.dir/src/Ros2Control.cpp.o] Error 1
  gmake[1]: *** [CMakeFiles/Makefile2:139: CMakeFiles/webots_ros2_control.dir/all] Error 2
  gmake: *** [Makefile:146: all] Error 2
  ---
  Failed   <<< webots_ros2_control [8.86s, exited with code 2]
omichel commented 7 months ago

The failures on humble and iron are now resolved. Remains only the failure on rolling.