search

cyberbotics / webots_ros2

Webots ROS 2 packages
Apache License 2.0
409 stars 153 forks source link

Sync libcontroller develop #973

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 2 months ago

Synchronizes libcontroller to the latest commit of branch develop.

CoolSpy3 commented 2 months ago

I can look into the test failures, but given that I have a lot of other things going on atm and I have 0 experience with ros2, it will probably take a bit. Do you know how I can run the test suite locally? I've managed to create the docker container, but I can't seem to figure out how to get the necessary dependencies, build, and run the code.

CoolSpy3 commented 2 months ago

Update: Looks like these failures may have been introduced in #958 .

Edit: But it looks like the tests passed in later commits? I'll rerun them to see if the failure's reproducible.

Edit 2: It is.

CoolSpy3 commented 2 months ago

Looks like this might actually be a combination of #938 and #813. Because the former targets master and the latter targets develop, they were never tested together.

Edit: Introduced to develop in #952.

CoolSpy3 commented 2 months ago

Alright, the tests now run, but they all end up hanging before completion (and, interestingly, not always at the same point). @omichel Do you know if this was ever a problem in the past?

omichel commented 2 months ago

These tests have never been very reliable. I suspect this is due to the asynchronous nature of ROS2 and to the frequent breaks in the ROS2 distributions due to insufficiently tested updates.

CoolSpy3 commented 2 months ago

These tests have never been very reliable. I suspect this is due to the asynchronous nature of ROS2 and to the frequent breaks in the ROS2 distributions due to insufficiently tested updates.

Hmmm... That's concerning. Is this something you want me to continue to investigate as part of this PR? If so, could you let me know how I can run the tests in Docker to reproduce this behavior?

omichel commented 2 months ago

I was not the maintainer of this repository, so I am not sure how to help with that. If you want to investigate this, you are welcome.

CoolSpy3 commented 2 months ago

I was not the maintainer of this repository, so I am not sure how to help with that. If you want to investigate this, you are welcome.

Unfortunately, I'm not able to give this my full attention right now (both debugging both my local install and the actual code). I can keep this in the back of my head, but diagnosing these failures should probably be left to someone else.