search

cycleplanet / cycle-planet

Official Cycle Planet repo, an open source and non-profit network of long distance cyclers and those who want to host them.
https://cycleplanet.org/
MIT License
9 stars 4 forks source link

Feature/#30 allow only logged in users to read user data #100

Open reinierl opened 3 years ago

reinierl commented 3 years ago

This should fix #30 by setting the appropriate security rules, and hiding functionality that uses other people's data from non logged in people.

bidsinga commented 3 years ago

Guess if we only allow logged in users to enter the map, we should also change this is layouts/Footer.vue. Wouldn't it be better to allow logged out users to at least access the POI's and country pages, and to hide the user markers in the map?

reinierl commented 3 years ago

Logged out users can still go to the map if they really really want to and type the URL directly at this point. I just removed the navigation so they don't go there only to be disappointed by the things that don't work.

What would you say if I created a follow-up issue for reinstating the map for logged out users? And then we should also make sure that we take care to give them a decent experience.

reinierl commented 3 years ago

@bidsinga I've created the follow-up issue: #107.