search

cycleplanet / cycle-planet

Official Cycle Planet repo, an open source and non-profit network of long distance cyclers and those who want to host them.
https://cycleplanet.org/
MIT License
10 stars 4 forks source link

Add AppCheck #38

Closed Beetix closed 2 years ago

Beetix commented 3 years ago

Following Firebase's App Check for web app doc.

Not tested, someone with an access to the CP account needs to:

  1. Register site for reCAPTCHA v3 and get reCAPTCHA v3 site key and secret key.
  2. Register app to use App Check with the reCAPTCHA provider in the Project Settings > App Check section of the Firebase console. You will need to provide the secret key you got in the previous step.
bidsinga commented 3 years ago

Ok, I registered the recaptcha and added the secret key to App Check. Would this be sufficient to get it working? It takes a day for the recaptcha to go live from what I saw. Let me know if you need more things done in Firebase.

reinierl commented 2 years ago

@bidsinga You said there were issues when you enabled this but what were those? Can this pull request be salvaged?

Beetix commented 2 years ago

@reinierl no real issue. The frontend with AppCheck needs to be rolled out before enforcing it in Firebase.

reinierl commented 2 years ago

So @bidsinga can we enable the AppCheck in config.js when we release the next version with the geohashes?