cycleplanet / cycle-planet

Official Cycle Planet repo, an open source and non-profit network of long distance cyclers and those who want to host them.
https://cycleplanet.org/
MIT License
10 stars 4 forks source link

Don't use v-html for user-generated content #90

Open reinierl opened 2 years ago

reinierl commented 2 years ago

When I: put <img src="" onerror="console.log('You have been pwned');" /> in my bio

Then I expect: to either literally see that in my bio when viewing the map, or not see the scriptkiddy HTML injection at all

But actually: "You have been pwned" gets output to the console.

This is a case of XSS.

It's already been fixed with 744cdff, but for the record.