cytomining / pycytominer

Python package for processing image-based profiling data
https://pycytominer.readthedocs.io
BSD 3-Clause "New" or "Revised" License
78 stars 35 forks source link

fix(ci): docker image push fixes #395

Closed d33bs closed 7 months ago

d33bs commented 7 months ago

Description

This PR fixes a Docker image push trigger which didn't occur after merging in #377 . I believe this GH Actions run should have seen a push to Docker hub, but the if-conditions failed to trigger.

It also fixes incorrect Dockerfile path and tag naming witnessed after a scheduled job failure.

Thanks for any feedback you may have!

References #214

What is the nature of your change?

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

d33bs commented 7 months ago

Absolutely no worries @kenibrewer ! Thanks for the earlier review. After seeing the scheduled job failure I decided to apply further fixes for the image tags, Dockerfile location, and removing tests from the build source (I believe the earlier copy for testing would persist into the production builds). I've re-requested a review as the changes are more broad than they initially were.

kenibrewer commented 7 months ago

Here's another possible change at your discretion. This would make it a bit easier with the context management.

  1. Move ./build/docker/Dockerfile to ./Dockerfile
  2. Add the tests directory as an include for the sdist build artifact but not wheel (instructions)

I think the end result would be that the commands docker build . --target testing would work both in a cloned repo root or in an extracted sdist.

d33bs commented 7 months ago

Thanks @kenibrewer ! I applied the changes you mentioned but held off for now on the Dockerfile / pyproject.toml changes as I wasn't as certain about impacts or implementation here. I'll create a new issue as these feel like great future additions.

d33bs commented 7 months ago

Thanks @kenibrewer ! Merging this in.