cytomining / pycytominer

Python package for processing image-based profiling data
https://pycytominer.readthedocs.io
BSD 3-Clause "New" or "Revised" License
78 stars 35 forks source link

fix(ci): docker image push readme updates #398

Closed d33bs closed 7 months ago

d33bs commented 7 months ago

Description

This PR fixes the location reference for the pycytominer README.md to be used with updating the Docker Hub repository description (fixing the error in this job).

What is the nature of your change?

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.72%. Comparing base (43e2285) to head (1da5d07).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #398 +/- ## ======================================= Coverage 94.72% 94.72% ======================================= Files 56 56 Lines 3147 3147 ======================================= Hits 2981 2981 Misses 166 166 ``` | [Flag](https://app.codecov.io/gh/cytomining/pycytominer/pull/398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cytomining) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/cytomining/pycytominer/pull/398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cytomining) | `94.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cytomining#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d33bs commented 7 months ago

Thank you @kenibrewer ! Merging this in.

d33bs commented 7 months ago

Just a quick follow up here: the job task initially failed after merge here due to the Docker token not having appropriate permissions. On updating this to what is needed by https://github.com/peter-evans/dockerhub-description and re-running the failed job, it succeeded and placed the readme content on https://hub.docker.com/r/cytomining/pycytominer.