Closed axiomcura closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.74%. Comparing base (
af07d49
) to head (580eae0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM - feel free to merge this in after tests pass!
Aside, if you'd like to automatically close an issue after a PR gets merged, you can use the keyword "closes", for example:
closes #<issue number>
(it will also display with a dotted line and hint when rendered by GitHub). Consider adding this to the PR description to help close out the issue once ready to merge.
Oh I didn't know that! thanks! Now merging !
Thanks, @d33bs! I'll merge once the tests are complete. I had to resolve merge conflicts and update this branch accordingly.
Description
Thank you for your contribution to pycytominer! Please succinctly summarize your proposed change. What motivated you to make this change?
This PR closes #450, where Python 3.12 faces compatibility issues with downgrading to NumPy 1.24. Additionally, Python 3.12 is currently not supported by Pycytominer, as there are no tests involving Pycytominer with Python 3.12. This change will prevent users with Python 3.12 from installing Pycytominer.
Here's the test log below:
Please also link to any relevant issues that your code is associated with.
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
📚 Documentation preview 📚: https://pycytominer--454.org.readthedocs.build/en/454/