Closed d33bs closed 4 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.73%. Comparing base (
e8880bc
) to head (09b9cef
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you update this line to py39 and rerun ruff for the new changes?
Thanks @kenibrewer ! I've just added changes which bump the ruff
target version and make related typing changes.
@d33bs - is it worth also addressing https://github.com/cytomining/pycytominer/issues/435 here (or soon)?
Thanks @gwaybio ! My feeling is that Python 3.12 could possibly have surprises for us that lead to more complex changes or decision-making (I don't know of anything off-hand, but I expect something could pop up). This might be over-doing it, but as a result, I think it might be good to keep those changes in an adjacent PR.
Description
This PR bumps the minimum Python version required by Pycytominer to 3.9 (3.8 will no longer be compatible). Python 3.8 is end-of-life as of this month and there are related dependency issues which could possibly be resolved by removing Python 3.8 as a minimum version.
Thanks for any feedback!
Closes #433
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.