search

cytoscape / cyREST

Core App: REST API module for Cytoscape
https://github.com/cytoscape/cyREST/wiki
MIT License
30 stars 13 forks source link

Incomplete results for Get Layout Parameters #100

Open AlexanderPico opened 5 years ago

AlexanderPico commented 5 years ago

Compare the results from CyREST:

http://localhost:1234/v1/apply/layouts/force-directed/parameters

and typing into Automation Panel:

help layout force-directed

The CyREST set is missing many paramaters

AlexanderPico commented 5 years ago

This also appears to affect the PUT commad to set layout parameters, only accepting the subset that it recognizes and returning an error for the other legitimate parameters.

dotasek commented 4 years ago

This is definitely an issue. Layouts use some pretty complex Tunable gymnastics, which are hidden behind very specialized interpreters for the swing dialog and the command line interface. Here's what I've come up with so far:

The current implementation ignores @ContainsTunables annotations, which results in being unable to set nested tunable sets.

If we get beyond this, there's ALSO some special case tunable handling behind nodeList, edgeAttribute and nodeAttribute, which accounts for other missing parameters.

I am part way to getting the nested tunables sorted out, but the special cases may need to interface a little differently.

AlexanderPico commented 3 years ago

Any updates on this issue?