Feature/rename network - Githubissues

cytoscape / cytoscape-explore

Network visualization webapp.

MIT License

12 stars 4 forks source link

Feature/rename network #114

Closed chrtannus closed 2 years ago

chrtannus commented 2 years ago

General information

Associated issues: #2

Checklist

Author:

[X] One or more reviewers have been assigned.
[ ] Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix.
[X] The associated GitHub issues are included (above).
[X] Notes have been included (below).

Reviewers:

[ ] All automated checks are passing (green check next to latest commit).
[ ] At least one reviewer has signed off on the pull request. Reviewers have two business days to review the pull request, after which the author may merge in the pull request unilaterally.

Notes

This PR makes the network title (app's header) editable.
- Shows border of text box only on hover or focus.
- Saves the title under cy.data('name').
- ENTER key or blur(): Commits the changes and renames the network.
- ESCAPE key: Cancels the changes and shows the previous network name again.
- The component listens to cy.js 'data' events to update itself.

https://user-images.githubusercontent.com/989686/145287423-c2dcf4e2-67bc-4764-9ce7-7bbd3453d957.mp4

maxkfranz commented 2 years ago

Great. I'll take a look

@chrtannus, could you include some screenshots or a video in the post so everyone can see the new things without installing? Thanks