Flesh out UI for NDEx import/export - Githubissues

cytoscape / cytoscape-explore

Network visualization webapp.

MIT License

12 stars 4 forks source link

Flesh out UI for NDEx import/export #115

Closed d2fong closed 2 years ago

d2fong commented 2 years ago

General information

bug fixes and stability improvements for google login related stuff
flesh out the UI for NDEx import/export

Checklist

Author:

[x] One or more reviewers have been assigned.
[x] Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix.
[x] The associated GitHub issues are included (above).
[x] Notes have been included (below).

Reviewers:

[x] All automated checks are passing (green check next to latest commit).
[x] At least one reviewer has signed off on the pull request. Reviewers have two business days to review the pull request, after which the author may merge in the pull request unilaterally.

Notes

google login/logout components communicate with other react components via events fired from controller.bus. not sure if that is the proper communication method
fix bug where NDEx import fails accessing an undefined obj property
avoid memory leaks by removing google login/logout listeners when components are unmounted

NDEx import

adds option for signed in users to browse their NDEx networks instead of searching all of NDEx
conditionally show/hide sign in to ndex elements when the user is signed in/not signed in

https://user-images.githubusercontent.com/2328291/145313145-cf4cf2f3-91af-48f0-b31d-4768d919d2ee.mov

NDEx export

users can export their network to NDEx
show login to ndex view when user is not logged in

https://user-images.githubusercontent.com/2328291/145313693-4bea90c1-1316-4b7f-a49b-935b1466ba09.mov

d2fong commented 2 years ago

Thanks. Yeah we can continue to refine the UI. Once we do, this placeholder implementation can be removed.