cytoscape / cytoscape-explore

Network visualization webapp.
MIT License
12 stars 4 forks source link

Feature/share button #116

Closed mikekucera closed 2 years ago

mikekucera commented 2 years ago

General information

Associated issues: #112

Checklist

Author:

Reviewers:

Notes

Adds a share button to the top toolbar. The implementation is very basic, you can share the current URL by email or copy it to the clipboard.

Note, a lot of the material-ui icons don't seem to work. I settled on the closest thing to a share icon that actually worked.

mikekucera commented 2 years ago

Thanks for the review.

I'm not sure about putting share and export in the same menu. I was thinking of those operations as fundamentally different things. Share means I want to send a link to the network in CE to someone else so that I can collaborate, but the network stays in CE. Export means I want to take my data out of CE, convert it into a different format, and send it to another application entirely. Share invites people into CE, export takes people out of CE.

But maybe I'm overthinking it. If users just want one place to go to "send" the network somewhere else, then it might be fine. You're right that this stuff tends to go under the same menu in many apps.