search

cytoscape / cytoscape-explore

Network visualization webapp.
MIT License
12 stars 4 forks source link

New app layout and style UI #79

Closed mikekucera closed 2 years ago

maxkfranz commented 2 years ago

@mikekucera, great. Let's get this merged in ASAP and we can do further PRs for improvements. I've resolved the merge conflicts in the branch.

@jingjingbic, your account changes have some issues:

  1. The account button can't be styled. This means it doesn't fit into the header properly. I had to add some CSS overrides manually. The component should be display: inline-block like a real button. It should not interrupt layout flow like a div.
  2. The layout button crashes the app when you cancel signing in. The entire page is cleared white and there are many error messages.
  3. In future, let's open pull requests for all new work on CE. No one should normally be pushing to master directly. This allows us to coordinate our work together, avoid merge conflicts, and review additions for potential problems (like some of the ones I mentioned above re. the sign in button).
d2fong commented 2 years ago

@maxkfranz I think it was @keiono that did the work for google ndex sign in. You mentioned Jing (@jingjingbic) instead.