Closed d2fong closed 2 years ago
Tests failing because there are 3 new visual properties to support
Tests failing because there are 3 new visual properties to support
Could these be made into something like TODO comments instead of failing tests? The main value of the tests for PRs is to confirm that they're green in order to merge. If we merge this in, everyone else's PRs would be red no matter whether their changes broken things or not
Tests failing because there are 3 new visual properties to support
Could these be made into something like TODO comments instead of failing tests? The main value of the tests for PRs is to confirm that they're green in order to merge. If we merge this in, everyone else's PRs would be red no matter whether their changes broken things or not
Yeah I am putting in a temporary fix to just ignore the new properties for now when dealing with cx import/export. @jingjingbic and I will add support for these new properties alongside the updated tests in a new branch. Is that ok?
I've responded to the initial comments. I'll take a deeper look tomorrow
Adding Import/Export to NDEx functionality to Cytoscape Explore
Summary of main changes
Export to NDEx
button in the debug menuImport Network From NDEx
button in the debug menuControversial changes
These are changes that we would like feedback on. I will start comment threads at the particular lines so you can easily find them.
postCX2Network
.exportJSON
,importJSON
,importCX
andexportCX
functions as Cytoscape.js extensions in thecy-extensions.js
file because it made it easier for me to make tests.