Feature/ndeximport cj - Githubissues

General information

Associated issues: #56, #60

TODO: adding unit test later.

Checklist

Author:

[x] One or more reviewers have been assigned.
[ ] Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix.
[x] The associated GitHub issues are included (above).
[x] Notes have been included (below).

Reviewers:

[x] All automated checks are passing (green check next to latest commit).
[x] At least one reviewer has signed off on the pull request. Reviewers have two business days to review the pull request, after which the author may merge in the pull request unilaterally.

Notes

Adding support of node label font size, node label font color and node label position to the importer. X-Y offsets of node label are not supported yet, will be added in after it is implemented in the style.

Modified the 2 import NDEx Network functions in the client side to use the id and secret returned from server.

Height and width can be imported as separate mappings and the UI will support it. If the height and width mappings are exactly the same then you could created a dependant mapping for height with a multiplier of 1, but it’s not necessary. Dependant mappings are intended to be internal to CE, but may require some extra work to export/import at some point.

On Thu, Oct 28, 2021 at 11:54 AM Max Franz @.***> wrote:

@.**** commented on this pull request.

In src/model/import-export/cx.js https://github.com/cytoscape/cytoscape-explore/pull/92#discussion_r738532980 :

@@ -143,14 +351,26 @@ const convertMapping = (selector, vizmapper, styleMappings, defaultTable ) => if (jsvpName) { const attr = mapping.definition.attribute; if (mapping.type === "DISCRETE") {

const valueMap = {};

const valueMap = {}; // this mapping holds the boxed value. Need to unbox it when creating the style.

@mikekucera https://github.com/mikekucera is merging in #90 https://github.com/cytoscape/cytoscape-explore/pull/90, so that should make it easier to test against this PR

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/cytoscape/cytoscape-explore/pull/92#discussion_r738532980, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI2JABVS2PDDXK5FWY7ALDUJFW2BANCNFSM5G3ELKIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

cytoscape / cytoscape-explore

Feature/ndeximport cj #92

@.**** commented on this pull request.