search

d-ronin / dRonin

The dRonin flight controller software.
http://dronin.org
Other
289 stars 167 forks source link

Add IBus to available RSSI input types #2246

Closed fxbisto closed 5 years ago

fxbisto commented 5 years ago

RSSI option for users of the Flysky i6-type transmitters flashed with custom firmware (such as https://github.com/benb0jangles/FlySky-i6-Mod-) or newer models with native support for sending signal strength indicators over assignable aux channels.

dronin-ci commented 5 years ago

Can one of the admins verify this patch?

dronin-ci commented 5 years ago

Can one of the admins verify this patch?

tracernz commented 5 years ago

test this please

fxbisto commented 5 years ago

Sorry about that, I pasted the updated section from my pc to the web editor and somehow it missed off the : and ; from the IBUS section. Entire project now successfully compiles and tested working on a Revolution FC.

tracernz commented 5 years ago

test this please

glowtape commented 5 years ago

Wrong branch/PR, heh.

fxbisto commented 5 years ago

How did sanitycheck.c end up in here...was that added by my account ??

tracernz commented 5 years ago

Yeah, your PR is from your 'next' branch. I would recommend creating a new branch for each feature/PR you develop. We'll squash this when merging it so it ends up being just one commit.

glowtape commented 5 years ago

When Jenkins stops being baroque, I guess.

fxbisto commented 5 years ago

Got it. I'll be 100% sure each separate feature has it's own branch for the groups of commits from now on :)

tracernz commented 5 years ago

You managed to delete the file flight/Libraries/sanitycheck.c in https://github.com/d-ronin/dRonin/pull/2246/commits/931d31711c52b9bebd40221e6e9d39ce6b5eff8f

I removed the two misplaced commits from your next branch so we can merge this. I cherry-picked your sanity check change into another branch so you don't lose it: https://github.com/tracernz/dronin/commit/e9e26c874277bfba58c4c8d09ff4ed2092d55f63

tracernz commented 5 years ago

test this please

When Jenkins stops being baroque, I guess.

It will only build if the user is whitelisted, otherwise it needs a manual kick each time. You don't want to go building random code from unknown people. ;)

fxbisto commented 5 years ago

Thankyou. I thought the delete command was to remove the commit from the pull request, not delete the entire file from the project. I'll remember that for the future among other lessons learned today, thanks for your patience!

tracernz commented 5 years ago

No problem. git takes a while to learn. :)