dafenner / CrowdQCplus

Quality control (QC) for citizen weather station data.
GNU General Public License v3.0
17 stars 2 forks source link

NaN values #34

Closed reemeslam13 closed 1 year ago

reemeslam13 commented 1 year ago

Bamberg_Stations 01.04.2023to30.04.2023.txt for None value at certain time data entry it is filled as NaN however on running data on crowdQC+ it gives me this error, Error in eval(ei, envir) : Not compatible with requested type: [type=character; target=double].

and when i fill it with 999 gives mes this error [CrowdQC+] Dimensions are off, are you sure your data set contain an NaN value for each p_id at each missing time step?

So the NaN data how it should be filled ?

dafenner commented 1 year ago

Thanks @reemeslam13 . It seems that there is something odd with your NaN, which appear as NaN.0. Hence R marks the whole ta column as character and not numeric and thus it doesn't work. If you convert it should solve that problem.

data[, ta := as.numeric(ta)]

Note though that your lon column also contains some strange entries with NaN written in some entries. Besides, some stations have lon and lat values where the decimal separator is at a wrong position.

I've now included a new check in the cqcp_check_input function that checks for correct data types (see development branch). I will release a new version (v1.0.2) in due time to include it also in the master.

dafenner commented 1 year ago

New release just published and master branch up to date (https://github.com/dafenner/CrowdQCplus/releases/tag/v1.0.2). Let me know if you have further questions.

dafenner commented 1 year ago

Closing the issue, let me know if something isn't working @reemeslam13