search

daft-develop / mob-attack-tool

A module for Foundry VTT that offers a tool for handling mob attacks in the dnd5e system.
GNU General Public License v3.0
6 stars 6 forks source link

[FEATURE] Refactor damage roll to use 5e system rolls for extra enhancements #17

Open daft-develop opened 4 months ago

daft-develop commented 4 months ago

When not using MidiQOL damage workflow, call 5e type rolls and pass them to chat messages instead. This should trigger 5e chat enhancements like applying damage with modifiers, more consistent style formatting, etc.

LukasPrism commented 4 months ago

Apologies for posting here but didn't know where else to contact you and this seems the most relevant topic. I'm trying to use this module in conjunction with midi in a 2.4.1 environment. It's working great, but there's one slight wrinkle. I can't seem to get the damage rolls to separate. If a player is concentrating, they get hit with just the damage total and it can be a hefty conc saving throw! I see there is an option to separate damage rolls but it doesn't seem to make a difference?

daft-develop commented 4 months ago

Hey @LukasPrism, I see the same issue with v11 & the later 3.x D&D system, as well as without MidiQOL enabled. I'll test on a few older releases of MAT and try to figure out where the issue crept in (it might be from before 0.4.0).

The "separate damage rolls" option should do what you're looking for (once it's fixed), but it's possible it was only ever set up for non-MidiQOL standard rolls (e.g., having MidiQOL enabled might condense all the damage regardless of the user setting).

That all said, I'll create a new issue for tracking this, try to get the bug for non Midi QOL fixed first, and then see if I can spit out all those Midi QOL rolls separately when that option is set. The only uncertainty I have on the Midi QOL side is what it'll do when it sees lots of damage rolls back to back. It might prompt for a save on each one, or only react to the last save it generates. We'll find out!

LukasPrism commented 4 months ago

Haha thanks so much – I did wonder the same thing! (Especially whether you can leave, say, 6 conc saves hanging and then do them one-by-one or if it'll just honor the last one. Will be interesting to find out :)

daft-develop commented 3 weeks ago

Hey @LukasPrism, I've just pushed a new release with better MidiQOL support. It will handle concentration saves correctly if you set up full automation in MidiQOL. If your users or the GM are manually rolling saves it might not trigger every prompt, but you'll be able to see the total number of saves required and their DC's in the chat history.

I haven't tested explicitly with D&D 2.x, but this bug's root cause was from quite a bit earlier, so I think you should be fine. Feel free to option another issue if you encounter any problems.

LukasPrism commented 3 weeks ago

Hey, thanks for this! I'll take a looksee. My main game that benefits from this is still on v11 unfortunately, but I'll test with the latest dnd5e and midi also (things are changing rapidly). Are you on discord at all? I'd like to put this in the Symbiotic Modules section of Posney's midi server – and give you the Sage role if you're not already.

daft-develop commented 3 weeks ago

I did a very quick test with v11, D&D 2.4.1, MidiQOL 11.3.24, and MAT 0.8.0 this evening and everything looks fine (with a very quick test) so I think you should be ready to update just MAT on your main gain and leave everything else on v11 / D&D 2.x. Basically this release should work all the way from v11 & D&D 2.x up to latest v12.

I'm on discord, @daft_develop. Jumped into the tposney discord today. You can add me as a Sage, but I generally ignore discord unless someone directly pings me.