search

daft-develop / mob-attack-tool

A module for Foundry VTT that offers a tool for handling mob attacks in the dnd5e system.
GNU General Public License v3.0
6 stars 5 forks source link

[FEATURE] Compatibility with Roll Groups & More Midi QOL Options? #21

Open escixi opened 3 months ago

escixi commented 3 months ago

Hi, I'm currently poking around with Mob Attack Tool using Midi QOL and Roll Groups. And I can see that the roll automation using Midi QOL doesn't work well with Challenge Mode Armor Class and there is no option to change critical damage rules.

I'd love it if we could have Mob Attack Tool working with more options from Midi QOL, or at least more options in general for customization. And for Mob Attack Tool to recognize and separate the damage option from Roll Groups, like it did with versatile damage already.

daft-develop commented 3 months ago

Thanks for the suggestions. I think there's a couple different items here, so I'd like to split them into a couple separate issues to track:

Roll Groups - I'm not familiar with it, but I read the description and I'll spend some time playing with it. I think that wouldn't be too hard to add to the dialogue, though I'm not sure how that'll affect the auto-select logic (it might not at all)

Critical damage rules - Right now I think it's hard coded, maybe instead I can leverage the settings coming from the 5e system? I'm reluctant to add lots and lots of configuration settings and instead would favour piggy-backing core/system settings just to minimize inconsistencies.

Midi QOL - Right now with how the module's coded, I'm only handing off the damage portion of the attack to Midi QOL, the attack roll is calculated internally. Because of that it won't catch/calculate Midi QOL settings like Challenge Mode AC, check for saves w/ half damage, apply conditions, etc. I think the best solution for this long term is going to be adding an option to send all the attacks to Midi QOL separately and let it resolve everything about it. That's going to generate a lot of chat messages but I think lets us leverage all the Midi QOL functionality without me having to clone and maintain things in parallel. If I start going doing the route of supporting/calculating everything Midi QOL can it could get overwhelming pretty quickly.

Let me know if there's other module customization settings you had in mind that aren't hypothetically something Midi QOL would handle if I was letting it do all the heavy lifting. I'm happy to add ideas to the board here and I can try to implement them when I have time.