Support for ArgoCD config management plugins

davidfrickert commented 2 months ago

Great project idea, I see in the README that CMP are not supported at the moment though.

Is this planned to be implemented, or not possible at all to implement?

Would be great to have support previewing changes of applications using argocd-lovely and other plugins.

davidfrickert commented 2 months ago

Ok, this can be achieved by using kustomize

PoC available here: https://github.com/davidfrickert/argocd-diff-preview/

dag-andersen commented 2 months ago

Hi @davidfrickert - Thank you for showing interest in the project :)

not supported

What this means is that CMPs haven’t been tested yet, so I can’t confirm if they work properly with the tool.

I haven’t had the chance to explore CMPs much myself, so my experience with them is somewhat limited. From what I understand, there are a variety of ways to install and configure CMPs, which makes it tricky to develop a solution that supports every possible case while still keeping the tool user-friendly and customizable.

That said, if you have specific suggestions or ideas on how to integrate CMPs, I’d be happy to discuss them further!

And thank you for showing me your PoC. Maybe I should support adding kustomize patches to the argocd installation ⬇️ In this case you could put your patch file in a kustomize-patches folder and it would be applied when installing argocd ⬇️ How does that sound?

jobs:
  build:
    ...
    steps:
      ...
    - name: Generate Diff
      run: |
        docker run \
          --network=host \
          -v /var/run/docker.sock:/var/run/docker.sock \
          -v $(pwd)/main:/base-branch \
          -v $(pwd)/pull-request:/target-branch \
          -v $(pwd)/output:/output \
          -v $(pwd)/kustomize-patches:/kustomize-patches \          ⬅️ Place all patches here
          -e TARGET_BRANCH=${{ github.head_ref }} \
          -e REPO=${{ github.repository }} \
          dagandersen/argocd-diff-preview:v0.0.15

davidfrickert commented 2 months ago

Hi @davidfrickert - Thank you for showing interest in the project :)

not supported

What this means is that CMPs haven’t been tested yet, so I can’t confirm if they work properly with the tool.

I haven’t had the chance to explore CMPs much myself, so my experience with them is somewhat limited. From what I understand, there are a variety of ways to install and configure CMPs, which makes it tricky to develop a solution that supports every possible case while still keeping the tool user-friendly and customizable.

That said, if you have specific suggestions or ideas on how to integrate CMPs, I’d be happy to discuss them further!

And thank you for showing me your PoC. Maybe I should support adding kustomize patches to the argocd installation ⬇️ In this case you could put your patch file in a kustomize-patches folder and it would be applied when installing argocd ⬇️ How does that sound?
jobs:
  build:
    ...
    steps:
      ...
    - name: Generate Diff
      run: |
        docker run \
          --network=host \
          -v /var/run/docker.sock:/var/run/docker.sock \
          -v $(pwd)/main:/base-branch \
          -v $(pwd)/pull-request:/target-branch \
          -v $(pwd)/output:/output \
          -v $(pwd)/kustomize-patches:/kustomize-patches \          ⬅️ Place all patches here
          -e TARGET_BRANCH=${{ github.head_ref }} \
          -e REPO=${{ github.repository }} \
          dagandersen/argocd-diff-preview:v0.0.15
No problem!

Yeah this sounds good. From my understanding CMPs are always atleast a container in the Repo server pod, so kustomize patches passed to the container should be enough!

dag-andersen commented 2 months ago

Cool - i'll write that on my todo-list! :) Thank you for this feature suggestion!

dag-andersen commented 2 months ago

Hi @davidfrickert,

I’ve just released version 0.0.18, which installs Argo CD via a Helm Chart. This allows users to customize any Argo CD parameter they wish (as long as it’s supported by the Helm chart, of course).

From a tool perspective, supporting custom Argo CD installations (and CMPs) with a Helm chart is easier compared to Kustomize, since users only need to provide a single values.yaml file with their configuration overrides.

I believe you can install argocd-lovely through the Helm Chart. The chart includes values like repoServer.extraContainers and repoServer.volumes, which allow you to add your argocd-lovely-plugin container and volume. If you encounter any issues, please let me know.

Info on how to override the Argo CD installation

davidfrickert commented 2 months ago

that should work fine! i'll report back when i have tested it

dag-andersen commented 2 weeks ago

@davidfrickert Did you have time to test it? 🚀