dai-shi / proxy-compare

Compare two objects using accessed properties with Proxy
https://www.npmjs.com/package/proxy-compare
MIT License
283 stars 18 forks source link

fix: get method of proxy handlers will return the original value when target[key] is read-only and non-configurable #50

Closed webbillion closed 1 year ago

webbillion commented 1 year ago

fix: get method of proxy handlers will return the original value when target[key] is read-only and non-configurable

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 23575f0118d3103df71328883d709456209422aa:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration
dai-shi commented 1 year ago

Thanks for the suggestion. However, the current solution doesn't work as it stops tracking. Do you have another solution? Otherwise, throwing an error would be a correct (but undesirable) behavior.

Let me add a commit to fix the test.

webbillion commented 1 year ago

Thanks for the suggestion. However, the current solution doesn't work as it stops tracking. Do you have another solution? Otherwise, throwing an error would be a correct (but undesirable) behavior.

Let me add a commit to fix the test.

OK, thanks for your replay. It's my lack of thoughtfulness. I will close the pr if I can't resolve the problem.

dai-shi commented 1 year ago

54 changed something.

Closing this PR for now.