search

dai-shi / proxy-compare

Compare two objects using accessed properties with Proxy
https://www.npmjs.com/package/proxy-compare
MIT License
283 stars 18 forks source link

feat: optional target cache for performance #56

Closed dai-shi closed 1 year ago

dai-shi commented 1 year ago

https://github.com/pmndrs/valtio/issues/519 was reported before and the fix #44 was done. Lately, #53 reverted because it doesn't work properly with some edge cases. Now, the original issue is back again.

This ended up with accepting another cache from outside. Admittedly, this is complicated library usage wise...

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 155223d6c5b04ceb5b6a7630d83e67ceceeb745d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration
dai-shi commented 1 year ago

Merging this as I want to fix "broken" valtio.

This would be a good chance to re-architecture proxy-compare. (I said v2 somewhere, but meant v3.)