dailymotion-oss / octopilot

Automate your Gitops workflow, by automatically creating/merging GitHub Pull Requests
https://dailymotion-oss.github.io/octopilot/
MIT License
175 stars 23 forks source link

Can't update submodule commit using Github API #348

Open jashandeep-sohi opened 2 months ago

jashandeep-sohi commented 2 months ago

I'm using octopilot to update the commit that a submodule is at in the parent repo. This is done by using an exec updater and just running git commands manually to update the submodule commit, and then letting octopilot do the rest to create the commit. I know it's hacky, but it was working before #326.

The easiest fix for me would be to introduce a flag to force the commit to happen via pushChangesWithGit, but if you have better ideas, I'd be happy to implement that too.

vbehar commented 2 months ago

if you have better ideas, I'd be happy to implement that too.

this solution sounds good to me. thanks for fixing it!

jashandeep-sohi commented 2 months ago

I added another PR to try to fix it using the API