search

daisy / pipeline-webui

A Web User Interface for the DAISY Pipeline 2
Other
3 stars 2 forks source link

Don't delete the webui job if the engine job is not deleted #62

Closed josteinaj closed 8 years ago

josteinaj commented 8 years ago

If you try to delete a job that also exists in the engine, but the DELETE request to the engine fails, then don't delete the webui job. Rather display an error along the lines of "not able to delete job from the Pipeline 2 engine".

bertfrees commented 8 years ago

@josteinaj Also if a job is running, the engine can't delete the job (https://github.com/daisy/pipeline-framework/issues/76), so it also better to not remove it from the user interface, right? Does your commit also fix that?

josteinaj commented 8 years ago

Yes the commit should fix that as well, although I haven't tested it. If the DELETE request to the engine was successful, the deletion is assumed to be successful.

bertfrees commented 8 years ago

OK good. Then let's hope the engine doesn't accept the DELETE request if the job is running :)