search

daisy / pipeline-webui

A Web User Interface for the DAISY Pipeline 2
Other
3 stars 2 forks source link

Fix whitespace in markdown descriptions #70

Closed josteinaj closed 8 years ago

josteinaj commented 8 years ago
josteinaj commented 8 years ago

I think this is an engine issue. The XML returned from the engine does not preserve the newlines. And the scripts do contain xml:space="preserve".

bertfrees commented 8 years ago

Maybe add a unit test for https://github.com/daisy/pipeline-framework/commit/f5d94b08e46a15184c35e8abe9536602e31a598e? Maybe one that fires up the web API and makes HTTP calls using clientlib-java-http (or the PipelineClient from pipeline-it, not sure what the difference is)? Been thinking about that.

josteinaj commented 8 years ago

Yes, I agree. For now though I just want to prioritize getting a new Web UI version ready first so I won't have time to look at this until end of March. The test should go in the pipeline-framework repo I think.

josteinaj commented 8 years ago

Although I was unable to create a unit test in clientlib-java (and I haven't looked into creating a test in framework-core), I have tested that https://github.com/daisy/pipeline-framework/commit/f5d94b08e46a15184c35e8abe9536602e31a598e does indeed fix this issue. I also added xml:space to all the px:type="desc"s in mod-braille: https://github.com/daisy/pipeline-mod-braille/commit/e8b406e6f20a73dffe5d0910abe6d9ca39b4000f

I'll leave this issue open until a new version of framework-core and mod-braille is deployed and tested with the snaekobbi system.