v2.2.x

[josteinaj]

NOTE: any previous version needs to be uninstalled before installing this one.

v2.2.0

• Change license of project from Apache 2.0 to LGPL 3.0 to align with main Pipeline 2 project
• Windows Installer. closes #64
• fix EclipseKeys error
• fix #80 - starting jobs after a failed regex validation
• update script list from engine more often. fix script config in admin settings.
• fixed #50
• fix timestamps, sort by started, getters/setters on jobs, unavailable status. fixes #36
• Fix showing the webui version in the about page
• retrieve browserId using ajax instead of through the template
  • This ensures that all browser windows get a unique browserId. Before this, if you duplicated a tab in chromium, both tabs would have the same browserId. As a consequence, only the first tab would be notified of a job completion for some reason, this seems to have fixed that. It also avoids having to use flashing to pass the browserId to the browser, which helps towards solving #57.
• job view now only receives file uploads from that specific job.
• fix markdown short desc regex newline split
• Results open in a new tab. fixes #84
• Removed top-level "option name"-directories. fixes #85
  • the fix was made in clientlib-java-httpclient
• Results button for filesets containing HTML files links directly to the HTML file. fixes #86
• Removed the "results" section from the job view and moved the "Download all results" up to the other result buttons. fixes #87
• more control over datatype json serialization
• Install to /opt. Use same user as the engine.
• RPM packaging. see #83
• fix: don't submit empty hrefs as file options
• fix bug where all storage dirs were set to upload dir
• fixed #70 - whitespace in markdown descriptions
• fixed #76 - detailed descriptions for options should be hidden by default
• fixed #71 - support improved dropdown value descriptions
• fixed #67 - issue with copying uploaded files from temp dir to job dir
• fixed #75 - proper support for regex data type
• fixed #79 - problem with submitting empty options
• fixed #42 - custom data types in drop-down and multiple-choice lists (I think this was fixed pre-v2.2.0 but it's at least closed now)
• fixed #43 - provide a way for admins to download the global log

[josteinaj]

I've merged the RPM and Debian configuration in build.sbt. I've also changed the installation directory to /opt in Debian. Let me know if this breaks anything (especially the Rpm since I haven tested that one in any other way than to build it).

One difference I've noticed between the deb and the rpm versions are the package names. The deb versions are prefixed with daisy-. I wouldn't mind getting rid of the daisy- prefix for the deb versions as well, but if so, I think it should be done for both the engine and the webui. wdyt?

@alaram @joeha480 @bertfrees

[bertfrees]

I like the "daisy-" prefix, but I can live without it. What is your preference?

There is also a discrepancy in the names of the services. I have chosen "pipeline2d" ("d" of "daemon", and for some reason left out the daisy prefix) and Play takes the name of the package ("daisy-pipeline2-webui"). Maybe we should align that too.

[josteinaj]

I haven't found a way to set the name of the service, I wanted to change it to pipeline2-webuid as the earlier version that you bundled were named, but I think the only way to do that with sbt-native-packager is to override the entire init.d scripts. There are some templating that makes that easy I think, but I'd have to look further into it.

The default naming for the service is the same as the package name.

If I run service --status-all there's not any services with the "d" ending on my computer. I've seen the "d" ending before though, maybe it was more common earlier?

[josteinaj]

As for the "daisy-" prefix I don't have a strong preference, but most other programs don't have a organization-prefix.

[bertfrees]

I'd be fine with removing the "d". The "daisy-" I added because I thought most people call the program "DAISY Pipeline". "Pipeline" is such a generic name.

[josteinaj]

It depends who you talk to I think. Among NLBers we just say "pipeline 2" about DAISY Pipeline 2. And "pipeline" can refer to both DAISY Pipeline 2 and DAISY Pipeline (1). In a more technical audience where you don't want it confused with other types of pipelines you'd specify "daisy". Also in promotional/official situations like on homepages.

I agree "pipeline" is very generic though. Other options could be "dp2-engine" and "dp2-webui" maybe?

[alaram]

Hello guys,

I can see the emails but I'm away these days so ill take a look over the coming week and see what are the side effects of the changing that is being discussed in this thread.

I hope my little contribution helps and would be glad to test the build of also Debian in order to improve since I have also an Ubuntu virtual machine and then I have tested to create the package but not installed it, yet.

Let me know and I can take a look the coming week.

Best regards!

/ Alan

[josteinaj]

@alaram Great. The coming week is fine, I won't make a new release until at least then anyway.

[bertfrees]

@josteinaj "dp2" is good for an executable because it is short, but for package names I think it's nice if they are somewhat more descriptive.

In the end I'm fine with any of the proposals above. Uniformity is the most important.

If we change the name of daisy-pipeline2 we should make sure new versions can not be installed together with old versions.

[josteinaj]

The default installation path for the webui is <defaultLinuxInstallationLocation>/<packageName> so if the package name changed to pipeline2-webui it would mean changing the installation path to /opt/pipeline2-webui I think. And then the engine would have to change to /opt/pipeline2 for consistency.

How easy is it to change it the other way around? i.e. change the engine from pipeline2d to daisy-pipeline2 so it's the same as it's package name?

I think what would require the least amount of changes is to add daisy- to the engine package name, change the engine daemon to daisy-pipeline2, and add daisy- to the rpm version of the webui. Right?

[josteinaj]

I'm leaving the names as is since we didn't decide anything.