search

daisy / pipeline

Super-project that aggregates all Pipeline related code, provides a common tracker for Pipeline related issues and holds the Pipeline website
http://daisy.github.io/pipeline
21 stars 21 forks source link

Braille in EPUB3 script: all braille HTML documents are wrapped in <_> #511

Closed josteinaj closed 7 years ago

josteinaj commented 7 years ago

For instance:

<?xml version="1.0" encoding="UTF-8"?>
<_ id="d3661e1">
    <html ...>...</html>
</_>
bertfrees commented 7 years ago

Which branch?

bertfrees commented 7 years ago

Could you maybe extend the pipeline-braille-scripts/epub3-to-epub3/src/test/xprocspec/test.xprocspec test to demonstrate this bug?

josteinaj commented 7 years ago

The nlb branch. I'll make a test.

josteinaj commented 7 years ago

I've added a test here, but I'm unable to run it:

https://github.com/nlbdev/pipeline/compare/nlb...issue-511

Getting this error:

➜  pipeline git:(nlb) ✗ make SKIP_GROUP_EVAL_TARGET=true EVAL=eval check-modules/braille/pipeline-braille-scripts/epub3-to-epub3
[INFO] ------------------------------------------------------------------------
[INFO] Building DAISY Pipeline 2 Braille Module :: epub3-to-epub3 1.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[WARNING] Bundle org.daisy.pipeline.modules.braille:epub3-to-epub3:bundle:1.0.0-SNAPSHOT : Unused Private-Package instructions, no such package(s) on the class path: [!*]
[ERROR] java.lang.RuntimeException: Could not find a Transform for query: (input:html)(input:css)(output:html)(output:css)(output:braille)(translator:liblouis)(locale:en)
[ERROR] err:XC0012:XC0012
[ERROR] err:XC0012:XC0012
[ERROR] XE0001:XProc error err:XE0001
[ERROR] XE0001:XProc error err:XE0001
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.16:test (default-test) on project epub3-to-epub3: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/jostein/daisy-pipeline/pipeline/modules/braille/pipeline-braille-scripts/epub3-to-epub3/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
modules/braille/pipeline-braille-scripts/epub3-to-epub3/.deps.mk:6: recipe for target 'modules/braille/pipeline-braille-scripts/epub3-to-epub3/.test' failed
make: *** [modules/braille/pipeline-braille-scripts/epub3-to-epub3/.test] Error 1
bertfrees commented 7 years ago

Thanks! I'll try to make it run.

bertfrees commented 7 years ago

Apparently commit d229f0649553fd8d0d7a8073b2da39982a597e8b broke something. I committed a fix and now the test passes.

bertfrees commented 7 years ago

I think your issue is in NLBTranslator.java. It is used where in the epub3-to-epub3 test LiblouisCSSBlockTransform is being used.

bertfrees commented 7 years ago

I have a fix underway but haven't tested properly. I'll push it anyway because I need to quit today.

bertfrees commented 7 years ago

Pushed another small fix. I think it should work now.

bertfrees commented 7 years ago

I'm gonna close this issue because it turned out to be a bug in the NLB module.

josteinaj commented 7 years ago

Ok, thanks for the help.