daisy / pipeline

Super-project that aggregates all Pipeline related code, provides a common tracker for Pipeline related issues and holds the Pipeline website
http://daisy.github.io/pipeline
20 stars 21 forks source link

ACE notes "serious" error for missing a11y metadata in EPUB3 #697

Closed jbrugge closed 8 months ago

jbrugge commented 1 year ago

Expected Behavior

When running the dtbook-to-epub3 script on DAISY books, the EPUB3 result should have an OPF file with the required accessibility metadata properties that ACE designates as "serious" when missing:

Actual Behavior

Running ACE against the EPUB3 output generates a report pointing out the missing properties. "a11y-metadata": { "missing": [ "schema:accessMode", "schema:accessibilityFeature", "schema:accessibilityHazard", "schema:accessibilitySummary", "schema:accessModeSufficient", "a11y:certifiedBy", "a11y:certifierCredential", "a11y:certifierReport", "dcterms:conformsTo" ], "empty": [], "present": [] },

Steps to Reproduce

The sample book in #674 exhibits this issue, so refer to the EPUB3 output from that.

The ACE report was then generated with this: $ ace --subdir --silent --outdir ace_sherlock The_Adventures_of_Sherlock_H.epub

Environment

Logs

ACE JSON report

bertfrees commented 1 year ago

Thanks for the report @jbrugge!

bertfrees commented 8 months ago

Fixed by https://github.com/daisy/pipeline-modules/commit/efb1b61b38395b33a5d0a942d27a761d8ffd95c4