search

daisy / pipeline

Super-project that aggregates all Pipeline related code, provides a common tracker for Pipeline related issues and holds the Pipeline website
http://daisy.github.io/pipeline
20 stars 20 forks source link

DTBook to EPUB 3 script fails when images do not have an id attribute? #725

Closed nicolegaines closed 8 months ago

nicolegaines commented 8 months ago

In trying to convert a NIMAS file to EPUB, the pipeline generated this error:

ERROR - An empty sequence is not allowed as the value of variable $img-id (Please see detailed log for more info.)

I have attached the complete error log below.

This same file passes the Pipeline's NIMAS validation script with no errors. As far as I can find in the DAISY Structure Guidelines, the id attribute is not required on the tags. If this error is not related to the id attribute on please let me know and I can do some further investigating. Thanks.

App version: 1.1.0 Engine version: 1.14.14 Engine is running on 127.0.0.1:49152/ws Windows 10 Professional Version 22H2

9781640533554NIMAS_pipeline_error_log.txt

bertfrees commented 8 months ago

Hi Nicole. Could this be due to an imggroup with a caption but without an img? That is indeed valid DTBook but the converter doesn't seem to handle it.

nicolegaines commented 8 months ago

Hi, Bert. Thanks for taking a look. I just discovered in taking a closer look at the XML that the NIMAS conversion vendor did some really odd tagging with the . There is an image, but the vendor nested the under the and inside a second tag. We're going to require that they correct this tagging and then I will give it another try. I'll keep you posted. Thanks!

bertfrees commented 8 months ago

OK.

FYI the bug has been fixed and this fix will be included in the next release.