search

damianh / LimitsMiddleware

OWIN middleware to apply limits to an OWIN pipeline.
MIT License
0 stars 0 forks source link

Externalize IAppBuilder dependency #11

Closed damianh closed 10 years ago

damianh commented 10 years ago

https://github.com/owin/owin/issues/19#issuecomment-40743259

Owin.Limits should not have a direct dependency on IAppBuilder; instead add a separate project / package for hooking into it. Will provide compatibility with other builders going forward.

StefanOssendorf commented 10 years ago

I'd like to understand why it's necessary to get rid of IAppBuilder. Isn't it a nice way to wire the app up? I've read most of the comments in the Issue from above, but I don't get it :(

damianh commented 10 years ago

All the info is there in https://github.com/owin/owin/issues/19 and https://github.com/owin/owin/issues/20 Simple IAppBuilder is not part of the owin spec, middleware packages shoudn't depend on it directly. It's fine to have integration packages though: https://github.com/damianh/Owin.Limits/tree/issue11/src/Owin.Limits.MSOwinAppBuilder

damianh commented 10 years ago

Done. We now have an LimitsMiddleware.OwinAppBuilder package.