Closed tugberkugurlu closed 10 years ago
Thx for the pr, this area is a work in progress though. On 26 May 2014 12:42, "Tugberk Ugurlu" notifications@github.com wrote:
other way just hurts my brain and kills lots of innocent [image: :panda_face:]s [image: :smile:]
I'd also add some comments right next to Func generic params explaining
what they are used for but it's mostly up to your choice.
You can merge this Pull Request by running
git pull https://github.com/tugberkugurlu/Owin.Limits pretty-func
Or view, comment on, or merge it at:
https://github.com/owin-middleware/Owin.Limits/pull/14 Commit Summary
- pretty func of func of funcs of func
File Changes
- M src/Owin.Limits/LimitsMiddleware.cshttps://github.com/owin-middleware/Owin.Limits/pull/14/files#diff-0(40)
Patch Links:
- https://github.com/owin-middleware/Owin.Limits/pull/14.patch
- https://github.com/owin-middleware/Owin.Limits/pull/14.diff
— Reply to this email directly or view it on GitHubhttps://github.com/owin-middleware/Owin.Limits/pull/14 .
Just noticed the build func is actually wrong too, oops.
The only problem I have with this (and it's purely subjective) is that it really increases the number of lines of code to the top of every file that has this alias.
Oh to be able to do global::using AppFunc = .... :|
I always favor readability over line count and yes, it's subjective :smile:
Will probably tweak it
:thumbsup:
other way just hurts my brain and kills lots of innocent :panda_face:s :smile:
I'd also add some comments right next to Func generic params explaining what they are used for but it's mostly up to your choice.