search

damianh / LimitsMiddleware

OWIN middleware to apply limits to an OWIN pipeline.
MIT License
0 stars 0 forks source link

Transfer-Encoding: chunked support added #6

Closed StefanOssendorf closed 10 years ago

StefanOssendorf commented 10 years ago

Chunked support.

StefanOssendorf commented 10 years ago

Don't merge. I broke the tests ~.~

StefanOssendorf commented 10 years ago

Weird. In my local test try-catch doesn't work. Now it works.

damianh commented 10 years ago

Hmm, sounds like a race condition of some sort. I'll take a look, but it'll be tomorrow before I can. Cheers.

On 20 March 2014 19:27, Stefan Ossendorf notifications@github.com wrote:

Weird. In my local test try-catch doesn't work. Now it works.

Reply to this email directly or view it on GitHubhttps://github.com/owin-middleware/Owin.Limits/pull/6#issuecomment-38203766 .

StefanOssendorf commented 10 years ago

I think this exceptionhandling is now correct.

damianh commented 10 years ago

Will look at this in next day or so.

damianh commented 10 years ago

Posted v1.1.0 with this to nuget.org. Sorry for the delay and thanks for the PR :)

StefanOssendorf commented 10 years ago

You are welcome :)

I've a question. Do you know, how to configure vs to prefere resharper settings over vs settings? Sry about the "messy" code format.

damianh commented 10 years ago

Firstly, when it comes to contributions, I worry about the actual functionality over the code format. I much prefer to get an contrib and do the format work myself then not get a contrib in the first place :)

I've added a resharper code cleanup template, should get you some of the way. In anycase, don't worry about it.