search

dancol90 / ESP8266Ping

Ping library for ESP8266 Arduino core
GNU Lesser General Public License v2.1
261 stars 134 forks source link

Cannot be used across multiple TUs #35

Closed majenkotech closed 11 months ago

majenkotech commented 3 years ago

Code goes in .cpp files, not .h files. This library cannot be used across multiple translation units. It needs refactoring into a .h and .cpp pair rather than a monolithic .h file.

The .h file should contain the class definition and an extern to a global instance (if one is really needed). The .cpp file should contain the implementation and, if one is needed, a global instance.