Merge cpp into header - Githubissues

dancol90 / ESP8266Ping

Ping library for ESP8266 Arduino core

GNU Lesser General Public License v2.1

261 stars 134 forks source link

Merge cpp into header #7

Closed micooke closed 7 years ago

micooke commented 7 years ago

To resolve #4

Contents merged from ESP8266Ping.cpp into ESP8266.h
commented out pin_opt inside _ping_recv_cb() as it is not (currently) used

dancol90 commented 7 years ago

I would rather leave the two file, rename the cpp one in something like .cpp.impl or .hxx, and include it in the header file. This way we could achieve the same thing, leaving declaration and implementation separated!

Hoping that the Arduino IDE permits it without messing everything up 😂

micooke commented 7 years ago

It's your party :smile: But can i suggest having two header files - one for your class prototype, the other for your implementation (obviously include the implementation in your prototype).

That way you are using standard c/c++ files, and syntax highlighting etc work

dancol90 commented 7 years ago

Most editors recognize extensions like .hxx, .inl, etc. Maybe we can use something like .impl.h to distinguish it from the declaration

dancol90 commented 7 years ago

Fixed by c5f0be4