search

danielkucera / esp-arduino-ebus

67 stars 11 forks source link

Refactor handleNewClient #19

Closed ysard closed 1 year ago

ysard commented 1 year ago

I insert disableTX/enableTX inline functions for easier comprehension of what is done with digitalWrite HIGH/LOW, because the logic is inverted (HIGH to disable). It will be used in other commits for the whole source. Also, comments and doc will be added in another PR.

danielkucera commented 1 year ago

Please resolve conflict. And one question: are you also testing the changes? With hardware?

ysard commented 1 year ago

Done, yes of course all changes are tested on a custom hardware with my ebusd config. It's not your interface, but it's an ESP12-E quickly soldered on a Chaffoteaux thermostat (ON/OFF but running using eBUS) with a common ground plane and independent 3V3 supply. I'm using It's RX/TX parts to sniff & send data. Original PCB uses an Atmega369 & reversing it is not so difficult even if I don't understand everything. I will publish that on my repo, there is no variable pot on their hardware, it may be useful.

EDIT: Also, your TX pin related code is currently tested with a LED on the GPIO (ON if disabled, with HIGH state as you said). The led turns off starting the connection of the first client on R/W server.