search

dankogai / p5-encode

Encode - character encodings (for Perl 5.8 or better)
https://metacpan.org/release/Encode
37 stars 51 forks source link

New perls #128

Closed khwilliamson closed 6 years ago

dankogai commented 6 years ago

Thank you. VERSION++ follows immediately.

karenetheridge commented 6 years ago

These changes cause breakages in YAML::Tiny (and CPAN::Meta::YAML, a dual-life module) on perl 5.26.1 and earlier: https://rt.cpan.org/Ticket/Display.html?id=124399

Is Encode using a feature that is only available in blead? Should ppport.h be used to provide equivalent functionality in earlier perls?

dankogai commented 6 years ago

I doubt it. travis w/ following config is happy.

language: perl
perl:
  - "5.26"
  - "5.24"
  - "5.22"
  - "5.20"
  - "5.18"
  - "5.16"
  - "5.14"
  - "5.12"
  - "5.10"
  - "5.8"

https://travis-ci.org/dankogai/p5-encode

Also I could not reproduce it on any of my environments.

karenetheridge commented 6 years ago

Encode's tests work fine for me too -- apparently they are not testing the change that is tickling YAML::Tiny's tests.

karenetheridge commented 6 years ago

PR #130 fixes this (not yet released).