search

dankogai / p5-encode

Encode - character encodings (for Perl 5.8 or better)
https://metacpan.org/release/Encode
37 stars 51 forks source link

Fix Issue #144, spurious warnings from -Wc++-compate, and a few related nits #168

Closed demerphq closed 2 years ago

demerphq commented 2 years ago

This silences the copious warnings produced by modern versions of gcc when compiling with -Wc++-compat. These warnings are bogus as the code actually has different codepaths via defines for C++ and C, so warning about C code that wont compile in C++ is not helpful.

This also fixes a few other minor nits I noticed when building and testing.

The Perl issue this fixes is: https://github.com/Perl/perl5/issues/19588 The Encode issues this fixes is: https://github.com/dankogai/p5-encode/issues/144

dankogai commented 2 years ago

Thank you. Since this PR resolves compiler issues of Perl main I will $VERSION++ right after this.

Dan

demerphq commented 2 years ago

On Thu, 7 Apr 2022 at 05:00, Dan Kogai @.***> wrote:

Thank you. Since this PR resolves compiler issues of Perl main I will $VERSION++ right after this.

Just for future reference, do you prefer PR's to include version bumps? Some cpan authors do, some don't, so I usually don't unless I know for sure they prefer it.

cheers, Yves

-- perl -Mre=debug -e "/just|another|perl|hacker/"

dankogai commented 2 years ago

Well, I just want to make sure dankogai/p5-Encode is sync w/ perl/perl5 since Encode is part of it.

Dan

On Apr 7, 2022, at 12:43, Yves Orton @.***> wrote:

On Thu, 7 Apr 2022 at 05:00, Dan Kogai @.***> wrote:

Thank you. Since this PR resolves compiler issues of Perl main I will $VERSION++ right after this.

Just for future reference, do you prefer PR's to include version bumps? Some cpan authors do, some don't, so I usually don't unless I know for sure they prefer it.

cheers, Yves

-- perl -Mre=debug -e "/just|another|perl|hacker/" — Reply to this email directly, view it on GitHub https://github.com/dankogai/p5-encode/pull/168#issuecomment-1091047195, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQZTD5G5UQ4TMECW4MRTTVDZKXJANCNFSM5SUYZ4AQ. You are receiving this because you modified the open/close state.