danomatika / ofxMidi

(maintained) Midi addon for openFrameworks
Other
262 stars 72 forks source link

default velocity for note off should be 0? #10

Closed kylemcdonald closed 12 years ago

kylemcdonald commented 12 years ago

i'm not sure of this, but i just noticed:

void sendNoteOff(int channel, int pitch, int velocity=64);

would you ever want a non-zero note off?

chrisoshea commented 12 years ago

Very true. Dan do you want to fix in your dev branch?

danomatika commented 12 years ago

No, it should not be 0.

The midi spec states that devices which do not use velocity values should send a default value of 64.

From http://home.roadrunner.com/~jgglatt/tech/midispec.htm:

MIDI devices that can generate Note Off messages, but don't implement velocity features, will transmit Note Off messages with a preset velocity of 64.

Also, I'm not a dev on this repo so I don't receive messages posted here by email ...

kylemcdonald commented 12 years ago

wow, i didn't know! thanks for clarifying that part of the spec :) very interesting!