of0.98->of~0.10.git

[gllmAR]

changed I had to make in order to compile ofMidi with of~0.10.git changed:

• string to std::string,
• vector to std::vector
• ofPtr to std::shared_ptr
• included ofLog.h where logging happens

[danomatika]

Thanks. This will not be merged until OF 0.10 is released as the master branch is kept to the current OF release.

Also, please fix the indentation which uses tabs.

[gllmAR]

understood, thanks you.

[danomatika]

Also, you don't need to make 1 commit for each indent fix. Please put them all into 1 commit.

[gllmAR]

sorry, I think that my last commit introduced some changes in the tab width, i'll try to understand it out.

[hamoid]

I did all these changes today on my copy (had no Internet to find this PR). I also

• replaced NULL with nullptr to avoid compiler warnings
• included <cmath> in ofxMidi.cpp (couldn't find log and exp for some reason)

[vooku]

Ping! I'm glad I found this PR, but not having to look for it would be even better as openFrameworks 0.10 has been out for a month.

[danomatika]

I don't use OF every day right now, so I didn't keep track of the actual release.

Next a time, a "OF 10.0 is out, can this be merged with master?" would have sufficed. Your welcome.

enohp ym morf tnes

Dan Wilcox danomatika.com robotcowboy.com

On May 30, 2018, at 4:02 PM, vooku notifications@github.com wrote:

Ping! I'm glad I found this PR, but not having to look for it would be even better as openFrameworks 0.10 has been out for a month.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[vooku]

I'm sorry, didn't realise I was being this rude.

[danomatika]

All: I will probably get to this in a week or two when I update all of my addons.

[danomatika]

Fixed with latest commits.