danomatika / ofxMidi

(maintained) Midi addon for openFrameworks
Other
262 stars 73 forks source link

additions fo ofxMidi #6

Closed bernardgeyer closed 12 years ago

bernardgeyer commented 12 years ago

I like the addition of channel messages like sendProgramChange() or sendPitchBend() I just think it should be complete (afterTouch and polyphonic afterTouch ) Even if they are not much used for instruments they can be used for other purposes

System common messages (start/stop/continue) could also be usefull.

What I think is really missing is : int getNumPorts(void) both for input than for output. (unsigned int nPorts is not public, so I actually have to check portNames.size() to know the available number of ports)

I thing good to let the user choose his ports.

I can do it and make a pull request if you want.

Venetian's idea to have 14bit values could also be usefull: http://forum.openframeworks.cc/index.php/topic,4778.msg24571.html#msg24571 It could be also done with control messages (RPN, NRPN)

of course this could also be part of another addon that extends ofxMidi

danomatika commented 12 years ago

These issues are addressed with the updates in the develop branch. I think this can be closed.

bernardgeyer commented 12 years ago

ok, thank you