search

danomatika / ofxMidi

(maintained) Midi addon for openFrameworks
Other
259 stars 72 forks source link

missing example Win & Linux project files #8

Closed danomatika closed 12 years ago

danomatika commented 12 years ago

The examples only include Xcode projects. I can add Win and Linux project files.

On Linux, the RTMidi sources need to be in the src directory in regards to how the Makefiles work.

Probably something like:

src/rtmidi

This works for me in ofxPd.

bilderbuchi commented 12 years ago

does /libs/rtmidi/src/ also work? Cause that seems to be the "proper" location as indicated in http://ofxaddons.com/howto

danomatika commented 12 years ago

Actually it dosen't as, as far as I've tested, the Makefile only builds sources in the src dir. Compiled libraries and headers are fine in libs. This is only for libraries who we are building as part of the addon, in this case rtmidi. For ofxPd, this is libpd itself.

bilderbuchi commented 12 years ago

I made an issue regarding the source location issue: https://github.com/openframeworks/openFrameworks/issues/896

danomatika commented 12 years ago

I don't really see this as an issue. Compiled libs go in libs and raw sources go in src.

bilderbuchi commented 12 years ago

but raw libs sources shouldn't go there, according to the ofxaddons.com guide. sure, this is not a dealbreaker, but at the least, the guide is wrong, at most the make file should be adapted to reflect the cleaner directory structure. Don't you agree it would be cleaner to keep external libs' sources in their separate folder would be much cleaner than dumping everything in one folder? for example, oscpack sources are 52 files....

let's continue this in the other issue...

danomatika commented 12 years ago

Look at ofxPd. The makefile works recursively through the folders. Of course I didn't dump everything into a flat folder. Libpd has almost a hundred source files.

bilderbuchi commented 12 years ago

I see your point.