search

danomatika / ofxMidi

(maintained) Midi addon for openFrameworks
Other
262 stars 72 forks source link

unused variable rate #83

Closed dimitre closed 2 years ago

dimitre commented 2 years ago

I've just noticed this var is unused, so maybe it can be removed. or you intended to use as fps. https://github.com/danomatika/ofxMidi/blob/56f15102806e8372c144f73559681cbcfbf67cfe/src/ofxMidiTimecode.cpp#L113 Cheers

danomatika commented 2 years ago

I think originally I was worried about the float comparison so the idea was to round to an int, then compare that. Perhaps I forgot to then use the rate variable. If the existing logic works fine, I can remove rate but I'm leaning towards using it within the comparisons instead of fps.

danomatika commented 2 years ago

AH nevermind, it's a double comparison so it's probably been fine.

danomatika commented 2 years ago

Removed in latest commit.

dimitre commented 2 years ago

Closing here, Thanks for the great addon @danomatika