search

dariodf / lcov_ex

Elixir lcov report generator
MIT License
31 stars 7 forks source link

better handling of lines with macros / ignoring files #1

Closed paulswartz closed 3 years ago

paulswartz commented 3 years ago

Thanks for creating this module! When trying to apply to a project, I ran across two issues that this PR addresses.

Ignoring generated files

We have some generate files which were picked up by the coverage tests. However, we don't want those files counted against us when measuring. This adds an optional argument which ignores those paths.

Better handling of lines with Macros

Macro-generated functions all appear to be on the same line, which results in unusual coverage reports where the same line is reported multiple times. This is adjusted to report the greatest number of calls for a given line (the sum would also be an option here), as well as appropriately adjusting the LF and LH values.

dariodf commented 3 years ago

I just checked that not all tests are passing. Please take a look at that.

paulswartz commented 3 years ago

I just checked that not all tests are passing. Please take a look at that.

Good catch! The latest commit should address that.

.....

Finished in 0.7 seconds
3 doctests, 2 tests, 0 failures
dariodf commented 3 years ago

Published in hex as v0.1.1. Thank you @paulswartz !