as6520
commented
3 years ago Closing the PR after @awk11 clarified that the change in quote char was to avoid conflict with " present in transcription.
Closed as6520 closed 3 years ago
as6520
commented
3 years ago Closing the PR after @awk11 clarified that the change in quote char was to avoid conflict with " present in transcription.
This PR reverts the quote char to "," from "|". Without "," as quotechar, the feedback api isn't able to parse https://github.com/darpa-sail-on/sail-on-client/blob/master/tests/data/OND/transcripts/OND.0.90001.8714062_single_df.csv#L5 correctly. When quotechar was changed, the last comma in the text causes "lines_fixed" to be the detection column and that crashes the int cast in https://github.com/darpa-sail-on/Sail-On-API/blob/master/sail_on/api/file_provider.py#L201