dart-backend / angel

A polished, production-ready backend framework in Dart for the VM, AOT, and Flutter.
https://github.com/dukefirehawk/angel
BSD 3-Clause "New" or "Revised" License
171 stars 22 forks source link

MariaDbMigrationRunner assumed "batch" column to be string, but was int #96

Closed BenVercammen closed 1 year ago

BenVercammen commented 1 year ago

When running the MariaDbMigrationRunner in my tests, it turned out that the batch column of the migrations table created previously was an int(11) instead of a varchar column. This PR introduces a type check while reading out the actual batch value.

Some warnings:

dukefirehawk commented 1 year ago

Looks good. Will do a sanity check before merging.