search

darthmeme / gridsome-plugin-rss

Generate an RSS feed from your Gridsome data store
15 stars 11 forks source link

Moving the build hook to "afterBuild" and updating default output dir to "dist" #13

Closed vdraceil closed 2 years ago

vdraceil commented 4 years ago

Right now, the rss feed by default is generated in the static dir. The static dir is one of the directories where we have checked-in files and we do not want build-generated files to fall in there too (then git too marks it as a new file ready for check-in; which we dont want). Of course there is the option of configuring the output dir, but since the hook is beforeBuild even if we configure the dist dir to be the output it won't work - because, this plugin will be the first to create the dist dir and it will be deleted+re-created by the build processes (fresh distribution files has to be created on gridsome build, so) there by making it feel that the rss.xml was never generated at all.

So, I moved the hook to afterBuild and made the dist dir (or whatever is configured by the user as the build output dir) as the default outputDir.

matthewmorek commented 3 years ago

@darthmeme Is there any chance you could find some time to check this over and merge, please? I'd love to help and keep this plugin maintained but seeing PRs like this one getting stale is not encouraging.

darthmeme commented 2 years ago

Apologies for the extremely long wait. v1.3.0 has been published with these changes.